An agent that paused for a restart on its open pull request goes on after it

A card in its pull-request phase: a review comment came in, and the agent was fixing it when Obeya announced a restart.

Before

  1. 10:203 new review comments, passed on to the agent.
  2. 10:22 · AgentThe checks are running. Then I commit, push and answer the three review threads.
  3. 10:23Obeya is about to restart; the agent pauses at the next safe point.
  4. 10:24 · AgentThe checks are green. I'm pausing again; after the restart: commit, push and the replies in the review.
  5. 10:24Obeya restarts and resumes the agents that were at work, but not this one: a card with an open pull request counted as waiting for its reviewers.
7 minutes of nothing: the fixes sit uncommitted, the reviewers wait.
  1. 10:31 · YouWhich restart? I don't see one being waited for.
  2. 10:31 · AgentObeya had announced a restart, so I paused. If none is pending, I'll go on now.

After

  1. 10:203 new review comments, passed on to the agent.
  2. 10:22 · AgentThe checks are running. Then I commit, push and answer the three review threads.
  3. 10:23Obeya is about to restart; the agent pauses at the next safe point.
  4. 10:24 · AgentThe checks are green. I'm pausing again; after the restart: commit, push and the replies in the review.
  5. 10:24Paused until Obeya has restarted.
  6. 10:24Obeya restarts. It noted that this agent was at work, and resumes it like any other.
  7. 10:24 · AgentCommits, pushes and answers the review threads, without anyone asking.
Idle pull requests stay asleepAn agent that was only waiting on its pull request when Obeya restarted is not woken: Obeya restarts many times a day, and each wake-up would cost a turn.
Also fixed: a restart that is called offWhen a restart of one repository's agents does not happen after all (its new configuration does not resolve), the agents that paused for it now go on at once. Before, they stayed paused until the owner wrote to them. A restart announced later reaches them again; before, they never heard of it.